-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add structure for feature flags #6491
Conversation
328f17a
to
009ad19
Compare
Should we implement something similar to https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#overview? |
I wasn't aware that k8s had a dedicated package for this :) I tried playing with it a bit but I got confused about how we're supposed to register flags with it 🤔, do you have any examples at hand? |
maybe check https://github.com/rhobs/observability-operator/blob/e09b23605cdfc824010a3934026136df1d15b031/cmd/operator/main.go#L81-L86 |
Gave it a try, let me know what you think :) |
41f4dd6
to
5e3ff79
Compare
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
conflicts resolved! |
Description
As discussed in the last office hours, we want to start to provide a few features behind feature flags. This PR introduces the concept, but still no feature flags are available.
They will be added as need in following PRs.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.